Skip to content

Test style change #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
audunmg wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Test style change #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b489cf
Proposition 1
audunmg Dec 12, 2025
263ca72
What about something like this?
audunmg Dec 12, 2025
d7c44a9
I forgot a closing quote
audunmg Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions varnish-enterprise/test/unit/_helpers.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@ chart_dir() {
echo "${BATS_TEST_DIRNAME}"/../..
}

helm_template_compare {
local valuefile="${BATS_TMPDIR}/values-${BATS_TEST_NUMBER}"
Copy link
Collaborator

@gquintard gquintard Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart!

echo "$1" > "$valuefile"
local templatefile="$2"
local jqpattern="$3"
local expected_result="$4"
local result=$(helm template --namespace default\
--values "$valuefile" \
--show-only "$templatefile" |
yq -c "$jqpattern"
)"
[ "$result" == "$expected_result" ]
}

app_version() {
yq -r '.appVersion' < "${BATS_TEST_DIRNAME}"/../../Chart.yaml
}
34 changes: 22 additions & 12 deletions varnish-enterprise/test/unit/service.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,37 @@ load _helpers

@test "Service: headless TLS service uses server TLS port instead of non-existent server.service.tls.port (non-regression test)" {
cd "$(chart_dir)"
local actual=$((helm template \
run helm template \
--set 'server.service.type=ClusterIP' \
--set 'server.service.clusterIP=None' \
--set 'server.service.https.enabled=true' \
--set 'server.tls.enabled=true' \
--set 'server.tls.port=443' \
--namespace default \
--show-only templates/service.yaml \
. || echo "---") | tee -a /dev/stderr |
yq -r '.spec.ports[1].port' | tee -a /dev/stderr)
[ "${actual}" = "443" ]
.
echo "$output"

[ "${status}" == 0 ]

local port=$( echo "$output" | yq -r '.spec.ports[1].port' )

echo Port: $port
[ "${port}" == "443" ]
}

@test "Service/externalTrafficPolicy: defaults to Cluster" {
cd "$(chart_dir)"

local object=$((helm template \
run helm template \
--namespace default \
--show-only templates/service.yaml \
. || echo "---") |
tee -a /dev/stderr)
.
echo "$output"

[ "${status}" == 0 ]

local actual=$(echo "$object" |
local actual=$(echo "$output" |
yq -r -c '.spec.externalTrafficPolicy' |
tee -a /dev/stderr)

Expand All @@ -36,14 +44,16 @@ load _helpers
@test "Service/externalTrafficPolicy: can be changed by user, for example Local" {
cd "$(chart_dir)"

local object=$((helm template \
run helm template \
--set 'server.service.externalTrafficPolicy=Local' \
--namespace default \
--show-only templates/service.yaml \
. || echo "---") |
tee -a /dev/stderr)
.
echo "$output"

[ "${status}" == 0 ]

local actual=$(echo "$object" |
local actual=$(echo "$output" |
yq -r -c '.spec.externalTrafficPolicy' |
tee -a /dev/stderr)

Expand Down
Loading