Test style change #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Proposition 1: basically use bats syntax better. use Everything printed in the test will be output when the test fails, so feel free to produce nice error messages. Every line need to succeed for the test to succeed, so adding multiple commands to test things in a single test is OK as long as it makes sense. |
Collaborator
Author
|
The second commit is not finished. It's just a suggestion to have a bash function to create a shorter "helm template test", since that's most of the tests. (it is what breaks tests right now in this PR) |
gquintard
reviewed
Dec 12, 2025
| } | ||
|
|
||
| helm_template_compare { | ||
| local valuefile="${BATS_TMPDIR}/values-${BATS_TEST_NUMBER}" |
Collaborator
|
@briiians ^ this should simplify your tests |
briiians
reviewed
Dec 16, 2025
briiians
added a commit
to briiians/helm-varnish
that referenced
this pull request
Dec 16, 2025
Co-authored-by: briiians <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test ergonomics aren't great, so let's improve it.