Makefile: fix inverted list of commands that use is_git_repo #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one 👍 |
hemanth
added a commit
that referenced
this pull request
Jan 5, 2016
Makefile: fix inverted list of commands that use is_git_repo
Collaborator
|
Thanks. |
Collaborator
|
Have it fixed the bug in v4.0.0? Or users have to update their version to get this bugfix? |
Contributor
Author
|
Homebrew only uses labeled releases. When a new v4.0.1 (or "v4.0.0a" or whatever) is made and released, Homebrew will be updated to pick it up. Until then Homebrew users will still have v4.0.0, which has the bug. |
Collaborator
|
@apjanke |
tardypad
pushed a commit
to tardypad/git-extras
that referenced
this pull request
Jul 13, 2016
Makefile: fix inverted list of commands that use is_git_repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #458 inverted the sense of the test for whether is-git-repo should be included in a file. This fixes it.
Fixes #493