Makefile: refactor is-git-repo inclusion logic #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the need for a big repeated block of code.
Collaborator
|
👍 |
hemanth
added a commit
that referenced
this pull request
Oct 2, 2015
Makefile: refactor is-git-repo inclusion logic
Contributor
Author
|
Thanks! |
Collaborator
|
Sweet! |
Closed
|
This patch does the wrong thing. For fallout see #493. |
Contributor
Author
|
Oh, jeez. Sorry about that. Here's a PR that fixes the sense of the test: #494 |
tardypad
pushed a commit
to tardypad/git-extras
that referenced
this pull request
Jul 13, 2016
Makefile: refactor is-git-repo inclusion logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a suggestion for refactoring the Makefile to simplify it. This avoids the need for a big repeated block of code for the command-construction logic, where the two blocks differ by only one line.