-
Notifications
You must be signed in to change notification settings - Fork 118
[close #749] Fix health checking issue #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #748 +/- ##
============================================
- Coverage 38.15% 37.92% -0.23%
+ Complexity 1614 1611 -3
============================================
Files 278 278
Lines 17493 17511 +18
Branches 1989 1991 +2
============================================
- Hits 6674 6641 -33
- Misses 10149 10210 +61
+ Partials 670 660 -10
☔ View full report in Codecov by Sentry. |
b210473 to
b14abce
Compare
pingyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
7f844f5 to
c08ea89
Compare
pingyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Signed-off-by: shiyuhang <[email protected]>
* optimize getregionstore logical Signed-off-by: shiyuhang <[email protected]> * decrease impact Signed-off-by: shiyuhang <[email protected]> * Update RegionManager.java Signed-off-by: shiyuhang <[email protected]> * [close #749] Fix health checking issue (#748) Signed-off-by: shiyuhang <[email protected]> * Update RegionManager.java Signed-off-by: shiyuhang <[email protected]> * add log Signed-off-by: shiyuhang <[email protected]> * change log level Signed-off-by: shiyuhang <[email protected]> --------- Signed-off-by: shiyuhang <[email protected]>
|
/cherry-pick release-3.3 |
Signed-off-by: shiyuhang <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
* optimize getregionstore logical Signed-off-by: shiyuhang <[email protected]> * decrease impact Signed-off-by: shiyuhang <[email protected]> * Update RegionManager.java Signed-off-by: shiyuhang <[email protected]> * Fix health checking issue (#748) Signed-off-by: shiyuhang <[email protected]> * Update RegionManager.java Signed-off-by: shiyuhang <[email protected]> * add log Signed-off-by: shiyuhang <[email protected]> * change log level Signed-off-by: shiyuhang <[email protected]> --------- Signed-off-by: shiyuhang <[email protected]> Co-authored-by: shiyuhang <[email protected]> Co-authored-by: shi yuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]> Co-authored-by: shi yuhang <[email protected]>
What problem does this PR solve?
Issue Number: close #749
pingcap/tispark#2707
Problem Description: StoreHealthyChecker fails to check the status of TiFlash
What is changed and how does it work?
Use isMppalive RPC to probe the status of TiFlash.
Check List for Tests
Manual test:
I have tested this locally with TiSpark. TiSpark will request TiFlash using client-java
Side effects
Related changes