Skip to content

Commit cb26d58

Browse files
authored
[fix #740] Add more logs in getregionstore (#751)
* optimize getregionstore logical Signed-off-by: shiyuhang <[email protected]> * decrease impact Signed-off-by: shiyuhang <[email protected]> * Update RegionManager.java Signed-off-by: shiyuhang <[email protected]> * [close #749] Fix health checking issue (#748) Signed-off-by: shiyuhang <[email protected]> * Update RegionManager.java Signed-off-by: shiyuhang <[email protected]> * add log Signed-off-by: shiyuhang <[email protected]> * change log level Signed-off-by: shiyuhang <[email protected]> --------- Signed-off-by: shiyuhang <[email protected]>
1 parent 71676ee commit cb26d58

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/main/java/org/tikv/common/region/RegionManager.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,13 @@ public TiRegion getRegionByKey(ByteString key, BackOffer backOffer) {
177177
Pair<Metapb.Region, Metapb.Peer> regionAndLeader = pdClient.getRegionByKey(backOffer, key);
178178
region =
179179
cache.putRegion(createRegion(regionAndLeader.first, regionAndLeader.second, backOffer));
180+
logger.debug(
181+
String.format(
182+
"get region id: %d with leader: %d",
183+
region.getId(), region.getLeader().getStoreId()));
180184
}
181185
} catch (Exception e) {
186+
logger.warn("Get region failed: ", e);
182187
return null;
183188
} finally {
184189
requestTimer.observeDuration();
@@ -240,6 +245,10 @@ public Pair<TiRegion, TiStore> getRegionStorePairByKey(
240245
}
241246
logger.info("Store {} is unreachable, try to get the next replica", peer.getStoreId());
242247
}
248+
// Does not set unreachable store to null in case it is incompatible with GrpcForward
249+
if (store == null || !store.isReachable()) {
250+
logger.warn("No TiKV store available for region: " + region);
251+
}
243252
} else {
244253
List<TiStore> tiflashStores = new ArrayList<>();
245254
for (Peer peer : region.getLearnerList()) {

0 commit comments

Comments
 (0)