fix(base-cluster/backup): fix secret creation for velero

[marvinWolff]

Summary by CodeRabbit

• Chores
  • Updated backup storage location configuration handling in deployment templates to reference updated configuration paths, affecting how backup storage locations are processed during deployment.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Updates the Velero credentials template to reference backup storage locations from the restructured configuration path .Values.backup.provider.velero.backupStorageLocations instead of .Values.backup.backupStorageLocations, aligning the template with the new values hierarchy.

Changes

Cohort / File(s)	Summary
Velero credentials path restructuring charts/base-cluster/templates/backup/velero/credentials.yaml	Updated iteration source for backupStorageLocations to use the new nested path under .Values.backup.provider.velero, reflecting a reorganization of the configuration values structure

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single file modification with straightforward configuration path update
• No logic changes, only values reference restructuring

Possibly related PRs

• fix(base-cluster): add missing value to template #1775: Related template restructuring that also migrates references from .Values.backup.backupStorageLocations to the .Values.backup.provider.velero path hierarchy.

Suggested labels

base-cluster

Suggested reviewers

• tasches
• cwrau
• teutonet-bot

Poem

🐰 With Velero's path now reorganized so neat,
Credentials flow through provider's heartbeat,
Values nested deeper, cleaner they stand,
Configuration harmony across the land! 🎯

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing secret creation for velero in the base-cluster backup configuration, which aligns with the changeset modifying the credentials.yaml template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/base-cluster/backup_fix_secret_creation

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e984d19 and 66a8635.

📒 Files selected for processing (1)

• charts/base-cluster/templates/backup/velero/credentials.yaml (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-07-24T09:55:53.655Z

Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1601
File: charts/base-cluster/templates/dns/external-dns.yaml:30-32
Timestamp: 2025-07-24T09:55:53.655Z
Learning: In charts/base-cluster/templates/dns/external-dns.yaml, the dns.provider field in values.yaml has always been expected to be a map format (e.g., `{ cloudflare: {} }`), never a string format. The template correctly uses `{{ .Values.dns.provider | keys | first }}` to extract the provider name from the map keys.

Applied to files:

• charts/base-cluster/templates/backup/velero/credentials.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: check licenses
• GitHub Check: lint helm chart (base-cluster)

🔇 Additional comments (2)

charts/base-cluster/templates/backup/velero/credentials.yaml (2)

1-18: Template logic alignment looks sound.

The conditional check on line 1 and the iteration source on line 3 reference the same path, and the credential rendering logic remains intact. The restructuring maintains the intended functionality.

---

3-3: Path restructuring is complete and consistent across all templates.

The change correctly updates the iteration source to .Values.backup.provider.velero.backupStorageLocations. Verification confirms:

• No references to the old .Values.backup.backupStorageLocations path remain in the codebase
• The new path is used consistently across three templates: credentials.yaml (line 3), velero.yaml (line 62), and validation.yaml (line 2)
• The conditional check on line 1 matches the range loop on line 3, ensuring proper alignment

The path change is complete and requires no further action.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @marvinWolff, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the base-cluster Helm chart concerning Velero backup secret creation. The fix ensures that the Helm template correctly references the configuration for Velero backup storage locations, which was previously misconfigured. This correction is vital for Velero to properly manage and utilize credentials for its backup operations, thereby enhancing the reliability of cluster backups.

Highlights

• Velero Secret Creation Fix: Corrected the Helm value path used to iterate over Velero backup storage locations, ensuring secrets are created from the intended configuration under $.Values.backup.provider.velero.backupStorageLocations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in the Velero backup credential creation by aligning the range loop's value path with the preceding if condition. My review includes a suggestion to further refactor this section by using a variable to store the long path, which will improve code readability and maintainability by avoiding repetition.