chore(main): [bot] release base-cluster:11.0.0 #1862
Conversation
teutonet-bot
requested review from
a team,
cwrau,
marvinWolff and
tasches
as code owners
|
Warning Rate limit exceeded@teutonet-bot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 14 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughBump release for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @teutonet-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated release by the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is an automated release for base-cluster:11.0.0. The changes correctly update the version in manifest.json and Chart.yaml. However, there are a couple of issues. The CHANGELOG.md file includes a cumulative log of all changes from much older versions, which makes it very long and hard to read. Additionally, a source URL in Chart.yaml still points to the previous version's tag. I've added comments with suggestions to address these points.
charts/base-cluster/CHANGELOG.md
Outdated
| ## [11.0.0](https://github.com/teutonet/teutonet-helm-charts/compare/base-cluster-v10.1.2...base-cluster-v11.0.0) (2025-12-05) | ||
|
|
||
|
|
||
| ### ⚠ BREAKING CHANGES | ||
|
|
||
| * **base-cluster/backup:** add k8up provider ([#1751](https://github.com/teutonet/teutonet-helm-charts/issues/1751)) | ||
| * **base-cluster/monitoring/alertmanager:** add receiver and route configuration capabilities ([#1600](https://github.com/teutonet/teutonet-helm-charts/issues/1600)) | ||
| * **base-cluster/ingress:** add option traefik for ingress controller and make it default ([#1420](https://github.com/teutonet/teutonet-helm-charts/issues/1420)) | ||
| * **base-cluster/monitoring:** migrate promtail to alloy ([#1347](https://github.com/teutonet/teutonet-helm-charts/issues/1347)) |
There was a problem hiding this comment.
The changelog for version 11.0.0 appears to be cumulative, including changes from many previous versions (e.g., 7.1.0 through 10.1.2). This makes the release notes for 11.0.0 excessively long and confusing.
For example, it includes entries for previous releases like:
* **main:** [bot] release base-cluster:10.1.2 ([#1841]...)* **main:** [bot] release base-cluster:7.1.0 ([#1237]...)
The changelog for a new version should ideally only list the changes introduced since the last version (10.1.2). This seems to be a configuration issue with how release-please is generating the changelog. It would be beneficial to correct this to ensure release notes are concise and accurate.
| - https://github.com/teutonet/teutonet-helm-charts/tree/main/charts/base-cluster | ||
| type: application | ||
| version: 10.1.2 | ||
| version: 11.0.0 |
There was a problem hiding this comment.
The sources URL on line 19 was not updated along with the version bump. It still points to the tag for the previous version (v10.1.2) and should be updated to point to v11.0.0.
Suggestion:
On line 19, please change:
- https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v10.1.2/charts/base-clusterto:
- https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v11.0.0/charts/base-cluster
teutonet-bot
changed the title
teutonet-bot
force-pushed
the
release-please--branches--main--components--base-cluster
branch
4 times, most recently
from
8ddb2cd to
3308f5d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (8)
charts/base-cluster/README.md (8)
92-96: Typo: “period restarting” → “periodic restarting”.- the descheduler might lead to period restarting of random pods. + the descheduler might lead to periodic restarting of random pods.
333-335: Typo: “you cluster” → “your cluster”.- so be aware that kyverno will need more resources in you cluster. + so be aware that kyverno will need more resources in your cluster.
242-246: Typo: “HelmRepositoy`s” → “HelmRepositories”.-- You can create [`HelmRepositoy`s](#global); `.global.helmRepositories.<name>.url=<url>` +- You can create [`HelmRepositories`](#global); `.global.helmRepositories.<name>.url=<url>`
396-398: Consistency: capitalize “Gateway API”.- but you can use [gateway api](https://gateway-api.sigs.k8s.io) + but you can use [Gateway API](https://gateway-api.sigs.k8s.io)
3151-3154: Formatting: unmatched backtick in description.- **Description:** Configuration of the `storageCostAnalysis dashboard + **Description:** Configuration of the `storageCostAnalysis` dashboard
4405-4416: Grammar: “it's” → “its”.- **Description:** A map of a ClusterRole name to it's rules + **Description:** A map of a ClusterRole name to its rules
4594-4601: Grammar: “it's” → “its”.- **Description:** A map of an account to it's (Cluster-)Roles + **Description:** A map of an account to its (Cluster-)Roles
4619-4624: Grammar: “it's” → “its”.- **Description:** A map of a role to it's intended namespaces + **Description:** A map of a role to its intended namespaces
🧹 Nitpick comments (3)
charts/base-cluster/README.md (3)
907-913: Pin external schema reference to a tag/commit to avoid drift.
Linking “Defined in” to main can change under readers’ feet across releases. Prefer a tag or commit SHA matching 10.2.0.- **Defined in** | https://raw.githubusercontent.com/teutonet/teutonet-helm-charts/main/charts/common/values.schema.json#/$defs/helmRepositories + **Defined in** | https://raw.githubusercontent.com/teutonet/teutonet-helm-charts/<tag-or-sha>/charts/common/values.schema.json#/$defs/helmRepositories
1676-1680: Markdown lint: wrap bare URLs or convert to links.
Convert plain URLs to <...> or text for MD034; keeps style consistent (MD049).- **Description:** See https://grafana.com/docs/grafana/latest/... + **Description:** See <https://grafana.com/docs/grafana/latest/...>- **Description:** This needs to follow flux's way of writing this url, see https://fluxcd.io/flux/components/source/gitrepositories/#url + **Description:** This needs to follow Flux's URL format; see <https://fluxcd.io/flux/components/source/gitrepositories/#url>Also applies to: 3994-3999
4136-4141: Update default git branch from "master" to "main" or document the choice.The schema default for the
branchproperty is set to"master"invalues.schema.json(line 1206). Since most repositories now use"main"as the default branch, either update this default to align with current conventions or add a comment explaining why"master"is retained.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/release-please/manifest.json(1 hunks)charts/base-cluster/CHANGELOG.md(1 hunks)charts/base-cluster/Chart.yaml(3 hunks)charts/base-cluster/README.md(37 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- .github/release-please/manifest.json
- charts/base-cluster/CHANGELOG.md
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-07-24T09:56:41.380Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.
Applied to files:
charts/base-cluster/README.mdcharts/base-cluster/Chart.yaml
📚 Learning: 2025-07-24T09:41:28.072Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Applied to files:
charts/base-cluster/README.mdcharts/base-cluster/Chart.yaml
📚 Learning: 2025-07-24T09:49:40.961Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
Applied to files:
charts/base-cluster/README.mdcharts/base-cluster/Chart.yaml
📚 Learning: 2025-07-24T09:41:28.072Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Applied to files:
charts/base-cluster/Chart.yaml
🪛 markdownlint-cli2 (0.18.1)
charts/base-cluster/README.md
454-454: Bare URL used
(MD034, no-bare-urls)
457-457: Emphasis style
Expected: underscore; Actual: asterisk
(MD049, emphasis-style)
457-457: Emphasis style
Expected: underscore; Actual: asterisk
(MD049, emphasis-style)
911-911: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: update metadata file for release
- GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (6)
charts/base-cluster/Chart.yaml (3)
19-22: ✓ Version and sources correctly updated for release.The version bump (10.1.2 → 10.2.0), sources URL, and common dependency (1.7.0) are all consistent and properly reflect the release metadata. This resolves the prior review concern about the sources URL needing an update.
34-34: ✓ Reflector image version correctly updated.The containerImage for reflector has been properly bumped from 9.1.42 to 9.1.44 as documented in the PR objectives.
47-47: Verify that kube-janitor is an intentional new chart dependency.A new artifacthub image entry for
docker.io/hjacobs/kube-janitor:23.7.0appears on line 47. The PR description doesn't explicitly mention kube-janitor as a new addition, though the changelog notes three updates (flux helmRepositories feature and two dependency bumps). Please confirm this is an expected part of the v10.2.0 release.charts/base-cluster/README.md (3)
3-3: LGTM: version badge updated to 10.2.0 matches release.
249-251: LGTM: Source Code link points to tagged base-cluster-v10.2.0.
258-259: Chart.yaml correctly specifies common 1.7.0 — requirements table alignment verified.The base-cluster Chart.yaml dependencies section matches the README.md requirements table exactly:
- Repository:
oci://ghcr.io/teutonet/teutonet-helm-charts- Version:
1.7.0
teutonet-bot
changed the title
teutonet-bot
force-pushed
the
release-please--branches--main--components--base-cluster
branch
4 times, most recently
from
9a3da6f to
91e1889
Compare
teutonet-bot
force-pushed
the
release-please--branches--main--components--base-cluster
branch
from
a39b10e to
f254bf9
Compare
🤖 I have created a release beep boop
11.0.0 (2025-12-10)
⚠ BREAKING CHANGES
Features
Bug Fixes
Miscellaneous Chores
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
Breaking Changes
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.