Skip to content

Temporal: Change subtract-from-last-representable-month tests #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
catamorphism wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Temporal: Change subtract-from-last-representable-month tests #4783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a2e8c2
Temporal: Change subtract-from-last-representable-month tests
catamorphism Dec 11, 2025
506ad4b
Update related tests
catamorphism Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions ...built-ins/Temporal/PlainYearMonth/prototype/add/subtract-from-last-representable-month.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,28 @@
// Copyright (C) 2024 Igalia, S.L. All rights reserved.
// Copyright (C) 2025 Igalia, S.L. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-temporal.plainyearmonth.prototype.add
description: RangeError thrown when adding negative duration to last representable month.
description: RangeError should not be thrown when adding negative duration to last representable month.
includes: [temporalHelpers.js]
features: [Temporal]
---*/

const lastMonth = new Temporal.PlainYearMonth(275760, 9);

// See https://tc39.es/proposal-temporal/#sec-temporal-adddurationtoyearmonth
// (step 10d)
assert.throws(RangeError, () => lastMonth.add({seconds: -1}));
assert.throws(RangeError, () => lastMonth.add({minutes: -1}));
assert.throws(RangeError, () => lastMonth.add({hours: -1}));
assert.throws(RangeError, () => lastMonth.add({days: -1}));
assert.throws(RangeError, () => lastMonth.add({weeks: -1}));
assert.throws(RangeError, () => lastMonth.add({months: -1}));
assert.throws(RangeError, () => lastMonth.add({years: -1}));
const durations = [
[{ seconds: -1 }, "seconds"],
[{ minutes: -1 }, "minutes"],
[{ hours: -1 }, "hours"],
[{ days: -1 }, "days"],
[{ weeks: -1 }, "weeks"],
];

durations.forEach(([duration, unit]) =>
TemporalHelpers.assertPlainYearMonth(lastMonth.add(duration), lastMonth.year, lastMonth.month, lastMonth.monthCode, `adding ${unit} to ${lastMonth}`)
);

TemporalHelpers.assertPlainYearMonth(lastMonth.add({ months: -1 }), lastMonth.year, 8, "M08", `adding months to ${lastMonth}`);

TemporalHelpers.assertPlainYearMonth(lastMonth.add({ years: -1 }), lastMonth.year - 1, lastMonth.month, lastMonth.monthCode, `adding years to ${lastMonth}`);

28 changes: 17 additions & 11 deletions ...-ins/Temporal/PlainYearMonth/prototype/subtract/subtract-from-last-representable-month.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,27 @@
// Copyright (C) 2024 Igalia, S.L. All rights reserved.
// Copyright (C) 2025 Igalia, S.L. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-temporal.plainyearmonth.prototype.subtract
description: RangeError thrown when subtracting duration from last representable month.
description: RangeError should not be thrown when subtracting duration from last representable month.
includes: [temporalHelpers.js]
features: [Temporal]
---*/

const lastMonth = new Temporal.PlainYearMonth(275760, 9);

// See https://tc39.es/proposal-temporal/#sec-temporal-adddurationtoyearmonth
// (step 10d)
assert.throws(RangeError, () => lastMonth.subtract({seconds: 1}));
assert.throws(RangeError, () => lastMonth.subtract({minutes: 1}));
assert.throws(RangeError, () => lastMonth.subtract({hours: 1}));
assert.throws(RangeError, () => lastMonth.subtract({days: 1}));
assert.throws(RangeError, () => lastMonth.subtract({weeks: 1}));
assert.throws(RangeError, () => lastMonth.subtract({months: 1}));
assert.throws(RangeError, () => lastMonth.subtract({years: 1}));
const durations = [
[{ seconds: 1 }, "seconds"],
[{ minutes: 1 }, "minutes"],
[{ hours: 1 }, "hours"],
[{ days: 1 }, "days"],
[{ weeks: 1 }, "weeks"],
];

durations.forEach(([duration, unit]) =>
TemporalHelpers.assertPlainYearMonth(lastMonth.subtract(duration), lastMonth.year, lastMonth.month, lastMonth.monthCode, `subtracting ${unit} from ${lastMonth}`)
);

TemporalHelpers.assertPlainYearMonth(lastMonth.subtract({ months: 1 }), lastMonth.year, 8, "M08", `subtracting months from ${lastMonth}`);

TemporalHelpers.assertPlainYearMonth(lastMonth.subtract({ years: 1 }), lastMonth.year - 1, lastMonth.month, lastMonth.monthCode, `subtracting years from ${lastMonth}`);