Temporal: Change subtract-from-last-representable-month tests #4783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the normative change proposed in tc39/proposal-temporal#3197 , these tests are no longer valid. Changed them so they require subtracting a duration from the last representable year-month to succeed, rather than throwing an exception.
ptomato
approved these changes
Dec 11, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
LGTM assuming the normative change gets consensus.
ptomato
added
the
awaiting consensus
Contributor
Author
|
Just pushed a patch to update two more tests that are similar, which I didn't notice the first time. |
Contributor
|
The additional tests may change based on comments in tc39/proposal-temporal#3197. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the normative change proposed in tc39/proposal-temporal#3197 , these tests are no longer valid. Changed them so they require subtracting a duration from the last representable year-month to succeed, rather than throwing an exception.