Add all possible inputs options to resolved caseFirst/numeric tests #4781
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The original tests added in #4504 now pass in V8, but when testing all possible input values for |
Contributor
Author
|
cc @FrankYFTang |
Contributor
|
LGTM It also surface two bugs in v8 . I fix them in https://chromium-review.googlesource.com/c/v8/v8/+/7253662 |
Contributor
thank you so much for adding these tests and inform me. |
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Dec 13, 2025
The bug is surfaced by incoming tests in tc39/test262#4781 Bug: 423663304 Change-Id: Ia3606bfc2023505eb59bbecbba7d48669d8c154d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7253662 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/main@{#104304}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.