Add coverage for resolved locale when Unicode extensions and options are present #4504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are present These tests currently fail in V8, but pass in JSC and SM.
FrankYFTang
reviewed
Nov 22, 2025
| // resolved locale. | ||
| { | ||
| locale: "en-u-nu-arab", | ||
| numberingSystem: "invalid", |
Contributor
There was a problem hiding this comment.
which line in the spec prevent "invalid" or "invalid2" to be used for numberingSystem?
Contributor
Author
There was a problem hiding this comment.
The relevant spec operation is ResolveLocale, step 13.k:
k. If SameValue(optionsValue, value) is false and keyLocaleData contains optionsValue, then
In the test case, optionsValue is "invalid" and value is "arab". SameValue("invalid", "arab") returns false, but because keyLocaleData doesn't contain a numbering system named "invalid", optionsValue is ignored and the numbering system defined in the Unicode extension sequence u-nu-arab is used.
This assumes that no valid numbering system is named "invalid". If it helps, we can adjust the test case to also include:
assert.sameValue(
Intl.supportedValuesOf("numberingSystem").includes("invalid"),
false,
"'invalid' is not a valid numbering system"
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests currently fail in V8, but pass in JSC and SM.