-
Notifications
You must be signed in to change notification settings - Fork 43
Update instructions for building from source #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… it is a part of python now
@Totktonada I've got several concerns:
|
Packages are installed from the distribution specific repositories. Any binary distribution must ensure binary compatibility of packages within a distribution version. A user should not meet any problems related to packages version on a distribution we support. I don't see frozen versions or recommendation to use it aside of PyYAML (the mentioned version is quite old anyway). I don't know why the instruction repeats |
Do you propose to extract dependencies from |
Is that about formatting on the web page? |
* `pyyaml <https://pypi.python.org/pypi/PyYAML>`_ version 3.10 | ||
* `argparse <https://pypi.python.org/pypi/argparse>`_ version 1.1 | ||
* `msgpack-python <https://pypi.python.org/pypi/msgpack-python>`_ version 0.4.6 | ||
* `gevent <https://pypi.python.org/pypi/gevent>`_ version 1.1.2 | ||
* `six <https://pypi.python.org/pypi/six>`_ version 1.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- argparse — it is built-in in Python 2.6+ AFAIR.
- msgpack-python is a submdoule of test-run, so it is not necessary to install it separately.
- All other versions seems obsoleted. And there is not any sense to list them, they're listed in
test-run/requirements.txt
in the format that pip understands. One who want to install it using a package manager can find related package names inrpm/tarantol.spec
ordebian/control
(but I would left this exercise to a user, just mention where to find it).
autoconf automake libtool zlib-devel \ | ||
readline-devel ncurses-devel openssl-devel \ | ||
libunwind-devel libicu-devel \ | ||
python python-pip python-setuptools python-devel \ | ||
python-msgpack python-yaml python-argparse python-six python-gevent | ||
python-msgpack python-yaml python-six python-gevent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's is not so trivial considering that it is Python 2 packages on CentOS 7, but Python 3 ones on CentOS 8 / Fedora. I would just suggest to use pip --user -r test-run/requirements.txt
or pip -r test-run/requirements.txt
from a virtualenv environments. We can mention that the same can be installed with packages, but, to be honest, if one want, (s)he will do it anyway based on the requirements.txt content. So, let's stick to pip
for simplicity.
Please, also eliminate mentions of 2.2 branch. It is not supported for a long time and useless for a user in fact. |
This section is something really strance. You should just have all dependencies available, build tarantool and run |
To be honest, I'm not sure those tools will works seamlessly. We use packpack and it is the only reliable way to build tarantool package ATM. I would just refer this instruction. |
It is either when we're about installing to some custom destdir and setting PATH (which is not actually necessary AFAIU). Or regarding installing directly to /usr or /usr/local bypassing a system package manager, which is not what I would suggest for anyone. |
We don't deploy and don't verify such packages. And the point regarding better performance comparing to |
There are no problems with 1.1.* known to me. |
However, okay, if it is /usr/local, it is more or less okay. Still requires root priveleges and dubious suggestion. Debatable topic. |
6998cbb
to
441ac4c
Compare
Outdated. See #1989 |
Fixes #1702
Fixes #1640