This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fix FIM pipeline with copilot #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
force-pushed
the
fim_pipeline
branch
from
392aa3d to
8f648b6
Compare
jhrozek
changed the title
Comment on lines
578
to
584
| # # this is a hotfix - we shortcut before selecting the output pipeline for FIM | ||
| # # because our FIM output pipeline is actually empty as of now. We should fix this | ||
| # # but don't have any immediate need. | ||
| # is_fim = self.proxy.context_tracking.metadata.get("is_fim", False) | ||
| # if is_fim: | ||
| # return | ||
| # |
There was a problem hiding this comment.
I think now is safe to remove this
There was a problem hiding this comment.
oops, yeah, for some reason I just commented out
aponcedeleonch
approved these changes
Dec 16, 2024
jhrozek
force-pushed
the
fim_pipeline
branch
from
8f648b6 to
b437298
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piping FIM through the pipeline didn't work because the message format is slightly different.
Fixes: #351