This repository was archived by the owner on Jun 5, 2025. It is now read-only.
FIM secrets warning can be tabbed and made into actual code #351
Assignees
Comments
|
This should not have happened. I think we are selecting the wrong pipeline because the secrets warning is produced by a special step in the pipeline called SecretRedactionNotifier which should not be selected for FIM (that's why we have a separate FIM and non-FIM pipeline btw). |
jhrozek
referenced
this issue
in jhrozek/codegate
Dec 15, 2024
This is not a real fix but a hotfix. The part that is needed and will be reused later is that we need to select the proper pipeline for FIM/non-FIM. What makes it a hotfix is that we shortcut for FIM requests as if we had no pipeline - this is OK for now because our FIM output pipeline is empty anyway, but we'll have to fix it. For some reason, piping the FIM output through the output pipeline throws errors. I'll look into that a bit more, but if we want to get the FIM output unblocked and without errors, this helps. Related: #351
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Unsure what we can do about this yet, but the UX is not that great
The text was updated successfully, but these errors were encountered: