Skip to content

Remove debug code for serialization failure #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
affifboudaoud wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove debug code for serialization failure #2208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
407ea4c
Remove debug code for serialization failure
affifboudaoud Oct 30, 2025
ba0bc1b
Move failed SDFGs to _dacegraphs
affifboudaoud Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions dace/codegen/codegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,24 +170,29 @@ def generate_code(sdfg: SDFG, validate=True) -> List[CodeObject]:
from dace.sdfg import SDFG
import difflib
import filecmp
import os
import shutil
import tempfile
with tempfile.TemporaryDirectory() as tmp_dir:
sdfg.save(f'{tmp_dir}/test.sdfg', hash=False)
sdfg2 = SDFG.from_file(f'{tmp_dir}/test.sdfg')
sdfg2.save(f'{tmp_dir}/test2.sdfg', hash=False)
print('Testing SDFG serialization...')
if not filecmp.cmp(f'{tmp_dir}/test.sdfg', f'{tmp_dir}/test2.sdfg'):
with open(f'{tmp_dir}/test.sdfg', 'r') as f1:
with open(f'{tmp_dir}/test2.sdfg', 'r') as f2:
diff = difflib.unified_diff(f1.readlines(),
f2.readlines(),
fromfile='test.sdfg (first save)',
tofile='test2.sdfg (after roundtrip)')
fromfile='pre.sdfg',
tofile='post.sdfg (after roundtrip)')
diff = ''.join(diff)
shutil.move(f'{tmp_dir}/test.sdfg', 'test.sdfg')
shutil.move(f'{tmp_dir}/test2.sdfg', 'test2.sdfg')
raise RuntimeError(f'SDFG serialization failed - files do not match:\n{diff}')
os.makedirs('_dacegraphs', exist_ok=True)
pre_path = os.path.abspath('_dacegraphs/serialization_failure_pre.sdfg')
post_path = os.path.abspath('_dacegraphs/serialization_failure_post.sdfg')
shutil.move(f'{tmp_dir}/test.sdfg', pre_path)
shutil.move(f'{tmp_dir}/test2.sdfg', post_path)
raise RuntimeError(f'SDFG serialization roundtrip mismatch for SDFG: \'{sdfg.name}\'.\n'
f'Files saved for inspection:\n Pre: {pre_path}\n Post: {post_path}\n'
f'File diff:\n{diff}')

if config.Config.get_bool('optimizer', 'detect_control_flow'):
# NOTE: This should likely be done either earlier in the future, or changed entirely in modular codegen.
Expand Down