Skip to content

Conversation

@affifboudaoud
Copy link
Collaborator

This looks like forgotten debug code to me? It moves the files to the main directory with the names test.sdfg and test2.sdfg. I suggest we remove this or move the files to _dacegraphs instead.

Remove file moves before raising RuntimeError for SDFG serialization failure.
@phschaad
Copy link
Collaborator

phschaad commented Nov 4, 2025

This was added to have them saved somewhere predictable for examination when the serialization test fails. I would vote for keeping the move command, but as you suggest, moving to _dacegraphs instead. Specifically, moving to _dacegraphs/serialization_failure_pre.sdfg and _dacegraphs/serialization_failure_post.sdfg or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants