Skip to content

Clean up some of the socket proxy code to simplify code #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'main' into cleanup_socket_proxy

689d824
Select commit
Loading
Failed to load commit list.
Open

Clean up some of the socket proxy code to simplify code #6256

Merge branch 'main' into cleanup_socket_proxy
689d824
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 30, 2025 in 0s

44.91% (target 40.00%)

View this Pull Request on Codecov

44.91% (target 40.00%)

Details

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.91%. Comparing base (787a646) to head (689d824).

Files with missing lines Patch % Lines
tests/testutils/socket_proxy.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6256      +/-   ##
==========================================
+ Coverage   44.89%   44.91%   +0.02%     
==========================================
  Files         390      390              
  Lines       26994    26998       +4     
==========================================
+ Hits        12119    12127       +8     
+ Misses      14008    14004       -4     
  Partials      867      867              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.