Skip to content

Clean up some of the socket proxy code to simplify code #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented May 27, 2025

fly by PR as I was rereading this code and found it could be tidied up a bit.

@atoulme atoulme requested review from a team as code owners May 27, 2025 17:56
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.91%. Comparing base (787a646) to head (689d824).

Files with missing lines Patch % Lines
tests/testutils/socket_proxy.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6256      +/-   ##
==========================================
+ Coverage   44.89%   44.91%   +0.02%     
==========================================
  Files         390      390              
  Lines       26994    26998       +4     
==========================================
+ Hits        12119    12127       +8     
+ Misses      14008    14004       -4     
  Partials      867      867              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jvoravong
Copy link
Contributor

The failing tests look legitimate and related. Please look into them.

Error: receivers/mysql/bundled_test.go:35:2: declared and not used: dockerSocketProxy
Error: receivers/mysql/bundled_test.go:56:98: undefined: dockerSocket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants