Update gradle tooling #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates gradle to use React-Native and Android's latest standards for improving dependency management.
|
Love the safeExtGet. Thanks! |
Collaborator
|
Thanks! And sorry for the wait. |
This was referenced Sep 15, 2019
Closed
roy8119425
pushed a commit
to roy8119425/react-native-admob
that referenced
this pull request
Apr 14, 2021
Updates gradle to use React-Native and Android's latest standards for improving dependency management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates gradle to use React-Native and Android's latest standards for improving dependency management.
Resolves #251:
compiletoimplementation, we comply with Android's new dependency configurations.implementationis slightly faster thanapi, and the purpose of this library is to expose admob, not its underlying dependencies (like Google Play), to anyone who adds it to their project.extblock to add these default properties, but if anyone is using older versions and does not have that block, this behavior will not change for them. (In case anyone wants to manually add this to an existing project, this is the best doc I've found.)