Skip to content

Conversation

@emretekince
Copy link

No description provided.

@miltoneiji
Copy link

Why 26 and not 27 since for Android Gradle Plugin 3.1.4, the minimum supported version is 27?

@jugutier
Copy link

We could try using RN rootProject prop so that it matches whatever RN is using.

I believe 56 is not up to date and still only supports 26

    compileSdkVersion rootProject.ext.compileSdkVersion
    buildToolsVersion rootProject.ext.buildToolsVersion

    defaultConfig {
        minSdkVersion rootProject.ext.minSdkVersion
        targetSdkVersion rootProject.ext.targetSdkVersion

@mdekrey
Copy link
Contributor

mdekrey commented Dec 27, 2018

See PR #393 for @jugutier's suggestion.

@koenpunt
Copy link
Collaborator

I've merged #393, so I think it should now be possible to override the value from the project implementing the library.

@koenpunt koenpunt closed this Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants