Replace ItemCtxt::report_placeholder_type_error match with a call to TyCtxt::def_descr
#143234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Jun 30, 2025
oli-obk
reviewed
Jun 30, 2025
Comment on lines
9
to
12
| help: you might have meant to open the body of the closure, instead of enclosing the closure in a block | ||
| | | ||
| LL - fn main() { | b : [str; _] | } | ||
| LL + fn main() | b : [str; _] | { } |
There was a problem hiding this comment.
also lmao this diagnostic is funnily wrong
There was a problem hiding this comment.
It's funnily wrong but has to do with the recovery for { |x| } which is apparently a ruby style closure
GuillaumeGomez
force-pushed
the
ice-143128
branch
from
845aa63 to
3d59877
Compare
This comment has been minimized.
This comment has been minimized.
|
Please squash the third commit into the first. There's no reason we need to have a separate commit just to add a test, especially if it's not demonstrating the behavior before the fix (which this one doesn't really need). |
GuillaumeGomez
force-pushed
the
ice-143128
branch
from
3d59877 to
af86816
Compare
|
Done. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
ice-143128
branch
from
af86816 to
068c8db
Compare
This comment has been minimized.
This comment has been minimized.
… to `TyCtxt::def_descr`
GuillaumeGomez
force-pushed
the
ice-143128
branch
from
068c8db to
74fda50
Compare
|
Didn't think about |
|
@bors r=oli-obk rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 1, 2025
Rollup of 8 pull requests Successful merges: - #143125 (Disable f16 on Aarch64 without neon for llvm < 20.1.1) - #143156 (inherit `#[align]` from trait method prototypes) - #143178 (rustdoc default faviocon) - #143234 (Replace `ItemCtxt::report_placeholder_type_error` match with a call to `TyCtxt::def_descr`) - #143245 (mbe: Add tests and restructure metavariable expressions) - #143257 (Upgrade dependencies in run-make-support) - #143263 (linkify CodeSuggestion in doc comments) - #143264 (fix: Emit suggestion filename if primary diagnostic span is dummy) Failed merges: - #143251 (bootstrap: add build.tidy-extra-checks option) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 1, 2025
Rollup merge of #143234 - GuillaumeGomez:ice-143128, r=oli-obk Replace `ItemCtxt::report_placeholder_type_error` match with a call to `TyCtxt::def_descr` Fixes #143128. We could likely use `tcx.def_descr` in more places (and therefore remove more `descr` methods). If it's something that we want to do, I can send a follow-up. r? `@oli-obk`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 1, 2025
…r=oli-obk Remove `ItemKind::descr` method Follow-up of rust-lang#143234. After this PR is merged, it will remain two `descr` methods: * `hir::GenericArg::descr` * `hir::AssocItemConstraintKind::descr` For both these enums, I don't think there is the right equivalent in `hir::DefKind` so unless I missed something, we can't remove these two methods because we can't convert these enums into `hir::DefKind`. r? `@oli-obk`
rust-timer
added a commit
that referenced
this pull request
Jul 1, 2025
Rollup merge of #143279 - GuillaumeGomez:rm-itemkind-descr, r=oli-obk Remove `ItemKind::descr` method Follow-up of #143234. After this PR is merged, it will remain two `descr` methods: * `hir::GenericArg::descr` * `hir::AssocItemConstraintKind::descr` For both these enums, I don't think there is the right equivalent in `hir::DefKind` so unless I missed something, we can't remove these two methods because we can't convert these enums into `hir::DefKind`. r? `@oli-obk`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143128.
We could likely use
tcx.def_descrin more places (and therefore remove moredescrmethods). If it's something that we want to do, I can send a follow-up.r? @oli-obk