Skip to content

rustdoc default faviocon #143178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

rustdoc default faviocon #143178

merged 1 commit into from
Jul 1, 2025
+1 −1

Conversation

eeshvardasikcm
Copy link
Contributor

@eeshvardasikcm eeshvardasikcm commented Jun 29, 2025 •
edited
Loading

#143154
default favicon now appears to be the new behavior, instead of no favicon.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 29, 2025
@eeshvardasikcm eeshvardasikcm changed the title Update the-doc-attribute.md (#1) Update the-doc-attribute.md Jun 29, 2025
@eeshvardasikcm eeshvardasikcm changed the title Update the-doc-attribute.md new default faviocon Jun 29, 2025
@eeshvardasikcm eeshvardasikcm marked this pull request as ready for review June 29, 2025 09:08
@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@eeshvardasikcm
Copy link
Contributor Author

eeshvardasikcm commented Jun 29, 2025 •
edited
Loading

I think this is the correct branch. I don't have authorization to push here. The issue that prompted this pull request said this is an easy task for new rust contributors.

I don't know if there is actually a need to do this favicon change to rustdoc. That would be a good thing to review.

Maybe someone has permissions for this to get it merged. I researched a little bit and master branch appears correct. Just following instructions.

The reason that master branch is the probable target for merge (according to my initial research) is probably something to do with the need for technical documentation code to be handled using human review.

I don't think I have sufficient permissions to fix the rustbot warning in the context of this pull request that already has my commit. If it is definitely a standard to remove those links, then I think I would have to make a new pull request that doesn't have the link depth details from my fork. My appologies.

@eeshvardasikcm eeshvardasikcm changed the title new default faviocon rustdoc new default faviocon Jun 29, 2025
@eeshvardasikcm eeshvardasikcm changed the title rustdoc new default faviocon rustdoc l default faviocon Jun 30, 2025
@eeshvardasikcm eeshvardasikcm changed the title rustdoc l default faviocon rustdoc default faviocon Jun 30, 2025
@eeshvardasikcm
Copy link
Contributor Author

eeshvardasikcm commented Jun 30, 2025 •
edited
Loading

I don't know if there is actually a need to do this favicon change to rustdoc. That would be a good thing to review.

Javadocs autogenerate if I remember correctly. The E-easy label on this issue probably doesn't require me to know these things yet.

@oli-obk oli-obk assigned oli-obk and unassigned notriddle Jun 30, 2025
@notriddle
Copy link
Contributor

It's definitely fine.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 30, 2025

📌 Commit c702055 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 1, 2025
Merged
bors added a commit that referenced this pull request Jul 1, 2025
@bors
Auto merge of #143267 - matthiaskrgr:rollup-suvzar6, r=matthiaskrgr
f46ce66 
Rollup of 8 pull requests

Successful merges:

 - #143125 (Disable f16 on Aarch64 without neon for llvm < 20.1.1)
 - #143156 (inherit `#[align]` from trait method prototypes)
 - #143178 (rustdoc default faviocon)
 - #143234 (Replace `ItemCtxt::report_placeholder_type_error` match with a call to `TyCtxt::def_descr`)
 - #143245 (mbe: Add tests and restructure metavariable expressions)
 - #143257 (Upgrade dependencies in run-make-support)
 - #143263 (linkify CodeSuggestion in doc comments)
 - #143264 (fix: Emit suggestion filename if primary diagnostic span is dummy)

Failed merges:

 - #143251 (bootstrap: add build.tidy-extra-checks option)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 79e96c0 into rust-lang:master Jul 1, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 1, 2025
rust-timer added a commit that referenced this pull request Jul 1, 2025
@rust-timer
Unrolled build for #143178
0d4989b 
Rollup merge of #143178 - eeshvardasikcm:master, r=notriddle

rustdoc default faviocon

#143154
default favicon now appears to be the new behavior, instead of no favicon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@eeshvardasikcm @rustbot @notriddle @bors @oli-obk