Added translations for splash/title/website metadata in Gatsby config #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for uk-reactjs ready! Built with commit 03bcd46 |
|
Deploy preview for uk-reactjs ready! Built with commit c2841e0 |
oleksii-polovyi
added
Потрібна допомога
oleksii-polovyi
requested changes
Mar 17, 2019
There was a problem hiding this comment.
@Kurzdor there seems to be a lot of extra spaces added in src/pages/index.js.
This will conflict with new changes that will be added to master in future.
Please fix them 😃
Also, https://reactjs.org is the original version of React.
@klymenkoo @mihilbabin should we keep it as https://uk.reactjs.org?
|
I think so. |
|
uk seems better to me. |
|
@ApolllonDev Fixed. |
vldmrkl
requested changes
Mar 18, 2019
| @@ -8,10 +8,10 @@ | |||
|
|
|||
| module.exports = { | |||
| siteMetadata: { | |||
| title: 'React: A JavaScript library for building user interfaces', | |||
| title: 'React: JavaScript-бібліотека для створення користувацьких інтерфейсів', | |||
There was a problem hiding this comment.
Suggested change
| title: 'React: JavaScript-бібліотека для створення користувацьких інтерфейсів', | |
| title: 'React – JavaScript-бібліотека для створення користувацьких інтерфейсів', |
Напевно, повинно бути тире замість двокрапки?
vldmrkl
added
Чекає на зміни
and removed
Потрібна допомога
This was referenced Mar 25, 2019
vldmrkl
added a commit
that referenced
this pull request
Mar 29, 2019
Finished #73: Added translations for splash/title/website metadata in Gatsby config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some parts of #67 issue