feat: calculate path substitutions in RestMethodInfo
#1897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the url target inside
RestMethodInfo, removing the use of regex on function calls.Re attempt at #1730. Turns out the additional allocations were caused by line 829 creating a closure. Looking at the lowered code C# always created the linq closure, even when round tripping was never used 🤔
In future I could optimise round trip to not use
string.Split, either manually splitting or usingSpan.SplitBenchmarks (on battery power)
Old benchmarks