Skip to content

Fix width parameters for input_select and input_slider #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcheng5 merged 2 commits into from
Jan 6, 2023
Merged

Fix width parameters for input_select and input_slider #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c24bb5c
Fix width parameters for input_select and input_slider
jcheng5 Jan 6, 2023
15d24bf
Add PR number to CHANGELOG
jcheng5 Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Bug fixes

* The `width` parameters for `input_select` and `input_slider` now work properly. (Thanks, @bartverweire!) (#386)

### Other changes


Expand Down
4 changes: 2 additions & 2 deletions shiny/ui/_input_select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from typing import List, Mapping, Optional, Tuple, Union, cast

from htmltools import Tag, TagChildArg, TagList, div, tags
from htmltools import Tag, TagChildArg, TagList, css, div, tags

from .._docstring import add_example
from .._namespaces import resolve_id
Expand Down Expand Up @@ -175,7 +175,6 @@ def input_select(
id=id,
class_=None if selectize else "form-select",
multiple=multiple,
width=width,
size=size,
),
(
Expand All @@ -188,6 +187,7 @@ def input_select(
),
),
class_="form-group shiny-input-container",
style=css(width=width),
)


Expand Down
2 changes: 1 addition & 1 deletion shiny/ui/_input_slider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ def input_slider(
props: Dict[str, TagAttrArg] = {
"class_": "js-range-slider",
"id": id,
"style": css(width=width),
"data_skin": "shiny",
# TODO: do we need to worry about scientific notation (i.e., formatNoSci()?)
"data_min": str(min_num),
Expand Down Expand Up @@ -211,6 +210,7 @@ def input_slider(
tags.input(**props),
*ionrangeslider_deps(),
class_="form-group shiny-input-container",
style=css(width=width),
)

if animate is False:
Expand Down