Skip to content

Fix width parameters for input_select and input_slider #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcheng5 merged 2 commits into from
Jan 6, 2023
Merged

Fix width parameters for input_select and input_slider #386

jcheng5 merged 2 commits into from
Jan 6, 2023

Conversation

@jcheng5
Copy link
Collaborator

@jcheng5 jcheng5 commented Jan 6, 2023 •
edited
Loading

The width was being applied to the control itself, when it really needed to be applied to the input container.

Fixes #385.

127 0 0 1_51894_

@jcheng5
Fix width parameters for input_select and input_slider
c24bb5c 
The width was being applied to the control itself, when it really
needed to be applied to the input container.
@jcheng5 jcheng5 requested a review from cpsievert January 6, 2023 01:12
@jcheng5
Copy link
Collaborator Author

jcheng5 commented Jan 6, 2023 •
edited
Loading

@schloerke Here's an example of a test app where we'd want to perform assertions against the computed width, as we hypothesized this morning. (see #385 for the example app source code and what it looked like before the fix)

cpsievert
cpsievert approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jcheng5 jcheng5 merged commit 2bbcc9d into main Jan 6, 2023
@jcheng5 jcheng5 deleted the 385-input-widths branch January 6, 2023 01:47
schloerke added a commit that referenced this pull request Feb 24, 2023
@schloerke
Merge branch 'main' into test-playground
bddc516 
* main:
  Fix docstring indentation
  Update HTML dependencies
  Eliminate duplicate random_port logic (#351)
  Fix width parameters for input_select and input_slider (#386)
  update shiny hex file path
  updated Shiny hex
  Fix broken examples
  Add Python 3.11 to setup.cfg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

width property doesn't work for some inputs

3 participants

@jcheng5 @cpsievert