Skip to content

Updated Harmonization tool to match the openAPI spec #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 18, 2022

Conversation

kevinlacaille
Copy link
Contributor

Related Issue(s):

Closes #772

Proposed Changes:

For inclusion in changelog (if applicable):

  1. Added the capability to harmonize data with more sensors. Previously, users could only harmonize with Dove Classic, however the openAPI spec has added Sentinel-2 as a target sensor for harmonization. Now, users can harmonize their data with Sentinel-2.

Diff of User Interface

Old behavior:

  • Could only harmonize Dove-R with Dove Classic.
    New behavior:
  • Can harmonize data with Dove Classic and Sentinel-2. The Sentinel-2 target only harmonizes PSScene surface reflectance bundle types (analytic_8b_sr_udm2, analytic_sr_udm2). The PS2 target only works on analytic bundles

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:
FYI: @cholmes @jreiberkyle

@kevinlacaille kevinlacaille marked this pull request as ready for review November 17, 2022 23:32
@kevinlacaille
Copy link
Contributor Author

@JuLeeAtPlanet I've added you to review the new wording in the docs.

Copy link
Contributor

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent @kevinlacaille !

Copy link
Member

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Suggested one small change.

@kevinlacaille kevinlacaille merged commit 2da698f into main Nov 18, 2022
@kevinlacaille kevinlacaille deleted the update_harmonize_tool-772 branch November 18, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sentinel-2 to Harmonization tool
4 participants