Skip to content

Validate target_sensor with a global set of target sensors #793

Closed
@kevinlacaille

Description

@kevinlacaille

Is your feature request related to a problem? Please describe.
Related to PR #780 / #780 (comment)

Validate the target_sensor input in planet.order_request() by checking if the value is found within a global set, say something like VALID_TARGET_SENSORS, that enumerates the option.

Describe the solution you'd like
Add the global, VALID_TARGET_SENSORS, which would contain all of the valid target sensors, in planet.specs.

In planet.specs around line 35:

VALID_TARGET_SENSORS = ["PS2", "Sentinel-2"]

In the tests.unit.test_order_request.test_harmonization_tool()

from planet.specs import VALID_TARGET_SENSORS
...
@pytest.mark.parametrize("target_sensor", VALID_TARGET_SENSORS)
<insert existing test here>

Additional context
An aside here: I want to point out that I'm pretty sure case-sensitivity doesn't matter as the target sensors get validated through planet.specs.get_match(), which is case-insensitive.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions