-
Notifications
You must be signed in to change notification settings - Fork 96
propose new request-update command #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have a few comments / questions in the review. I think it'd be good to get this merged in soon. I think it'd be good to get like a 'status' on different operations in our design docs, so we can mark that this is 'not yet implemented', but having it in the doc makes the plan clear. Then we can have a workflow where implementors of functionality should update the design-doc status.
User Story: As a CLI user I would like to create a request for an order from a | ||
template, overriding the name. | ||
|
||
``` | ||
$ planet orders request --like - --name IAmACopy < request.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you use the '<' here instead of just planet orders request --like request.json --name IAmACopy
? The '<' is still beyond my command-line knowledge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, really, there is no reason for using < requests.json
instead of just using requests.json
@cholmes FYI |
|
||
$ planet orders request \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from flags to positional
note, this is likely not a pre-release issue and can be treated as low-priority
This update to the CLI-Orders design doc is a proposal for not implementing the
--like
functionality inplanet orders request
but instead creating a new command,planet orders request-update
which will implement the--like
functionality. This allowsplanet orders request
to have required options actually be arguments (saves many keystrokes and trial and error).