Skip to content

Only pass dbUrl to Drush if set. #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grayside merged 2 commits into from
Feb 28, 2018
Merged

Only pass dbUrl to Drush if set. #342

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7301c9b
Only pass dbUrl to Drush if set.
jhedstrom Jan 26, 2018
24f054d
Merge remote-tracking branch 'origin/master' into 341-fix-empty-drush…
Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tasks/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ module.exports = function(grunt) {

if (dbUrl) {
dbUrl = '--db-url=' + dbUrl;
args.push(dbUrl);
}

grunt.config(['drush', 'install'], {
args: args.concat(['site-install', '-yv', profile, dbUrl]),
args: args.concat(['site-install', '-yv', profile]),
Copy link
Contributor

@grayside grayside Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhedstrom it seems like this means the --db-url flag would be serialized into the command before site-install, e.g., drush --db-url=mysql://... site-install -yv standard. Would that work?

Copy link
Member Author

@jhedstrom jhedstrom Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grayside in testing drush seemed not to care (I had the same thought).

options: _.extend({
}, cmd)
});
Expand Down