Only pass dbUrl to Drush if set. #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jhedstrom
commented
Jan 26, 2018
jhedstrom
commented
- Fixes PHP notice in install task on Drush 9 #341
grayside
reviewed
Feb 27, 2018
|
|
||
| grunt.config(['drush', 'install'], { | ||
| args: args.concat(['site-install', '-yv', profile, dbUrl]), | ||
| args: args.concat(['site-install', '-yv', profile]), |
Contributor
There was a problem hiding this comment.
@jhedstrom it seems like this means the --db-url flag would be serialized into the command before site-install, e.g., drush --db-url=mysql://... site-install -yv standard. Would that work?
Member
Author
There was a problem hiding this comment.
@grayside in testing drush seemed not to care (I had the same thought).
…-arg * origin/master: For Drupal 8 packaging, loading composer.json from repo root. (#331) Update dependencies to enable Greenkeeper 🌴 (#322) Drop PHP 5.5 and Node 4, 5, and 7 (#345) Add conflict with behat >= v3.4 (#343) Add cli service to docker-compose. Add support for docker-based test execution. Add documentation on local testing & development. add missing semicolon fix githooks task to properly merge in configured tasks from Gruntconfig.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.