-
Notifications
You must be signed in to change notification settings - Fork 362
Add ASP.NET Core telemetry metrics and traces for .NET 10 #3012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASP.NET Core telemetry metrics and traces for .NET 10 #3012
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3012 +/- ##
==========================================
+ Coverage 69.60% 69.71% +0.11%
==========================================
Files 413 403 -10
Lines 16185 16138 -47
==========================================
- Hits 11265 11251 -14
+ Misses 4920 4887 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Is the intention that this replace #2873? |
| OpenTelemetry.Instrumentation.AspNetCore.AspNetCoreTraceInstrumentationOptions.EnableBlazorSupport.get -> bool | ||
| OpenTelemetry.Instrumentation.AspNetCore.AspNetCoreTraceInstrumentationOptions.EnableBlazorSupport.set -> void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I prefer this shorter name, but asking as I had the thought on the other PR, should this instead be EnableAspNetCoreBlazorSupport for consistency with the other property names?
I didn't see it. But it could replace it. |
OK I'll close that one (as the CI is failing) in favour of this one. Could you copy over the test from https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2873/files#diff-aebeb6657672039acc0cda146bade415e420a70e30fb6571c73f5df05cd6c2bd please (assuming it still makes sense), then I can enable it in #2822 after this is merged and I rebase it. |
|
PR updated with feedback. |
...emetry.Instrumentation.AspNetCore/AspNetCoreInstrumentationMeterProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…entationMeterProviderBuilderExtensions.cs
|
|
||
| ## Unreleased | ||
|
|
||
| * Added support for listening to ASP.NET Core Blazor activities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it Blazor only, or it should be adjusted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics were added for many features.
Activities were only added for Blazor.
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Fixes #3014
Changes
Add ASP.NET Core telemetry metrics and traces for .NET 10
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes