Skip to content

Conversation

@pavelsavara
Copy link

@pavelsavara pavelsavara commented Jul 2, 2025

Contributes to dotnet/aspnetcore#62145

Changes

  • adds Microsoft.AspNetCore.Components and Microsoft.AspNetCore.Components.Server.Circuits tracing sources into AspNetCoreInstrumentationTracerProviderBuilderExtensions.AddAspNetCoreInstrumentation
    • can be disabled by new AspNetCoreTraceInstrumentationOptions.EnableAspNetCoreBlazorSupport = false
  • adds Microsoft.AspNetCore.Components and Microsoft.AspNetCore.Components.Server.Circuits into AspNetCoreInstrumentationMeterProviderBuilderExtensions.AddAspNetCoreInstrumentation

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 2, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore label Jul 2, 2025
@pavelsavara pavelsavara marked this pull request as ready for review July 2, 2025 11:48
@pavelsavara pavelsavara requested a review from a team as a code owner July 2, 2025 11:48
@pavelsavara pavelsavara marked this pull request as draft July 4, 2025 13:42
@pavelsavara
Copy link
Author

Paused this PR until dotnet/aspnetcore#62555 and dotnet/aspnetcore#62556 pass formal review

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 12, 2025
@Kielek Kielek removed the Stale label Jul 16, 2025
@pavelsavara pavelsavara marked this pull request as ready for review July 18, 2025 12:44
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 26, 2025
@Kielek Kielek removed the Stale label Jul 28, 2025
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 12, 2025
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.74%. Comparing base (5298d31) to head (3454511).
⚠️ Report is 17 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
- Coverage   69.75%   69.74%   -0.01%     
==========================================
  Files         386      386              
  Lines       15855    15854       -1     
==========================================
- Hits        11059    11058       -1     
  Misses       4796     4796              
Flag Coverage Δ
unittests-Instrumentation.AspNet 76.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...reInstrumentationMeterProviderBuilderExtensions.cs 100.00% <ø> (ø)
...eInstrumentationTracerProviderBuilderExtensions.cs 95.34% <ø> (ø)
...spNetCore/AspNetCoreTraceInstrumentationOptions.cs 95.45% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello
Copy link
Member

Closing in favour of #3012.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants