Upgrade to the latest proto version #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
requested review from
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
tigrannajaryan
approved these changes
Mar 16, 2020
| resource *Resource | ||
| metrics []Metric | ||
| resource *Resource | ||
| instrumentationLibraryMetrics []InstrumentationLibraryMetrics |
Member
There was a problem hiding this comment.
Any chance we can shorten the type and field names?
Member
|
Mergin for now to move forward. @bogdandrutu please have a look at the comments and possibly add issues to address later. |
bogdandrutu
referenced
this pull request
in bogdandrutu/opentelemetry-collector
Mar 16, 2020
Signed-off-by: Bogdan Drutu <[email protected]>
tigrannajaryan
pushed a commit
that referenced
this pull request
Mar 18, 2020
Resolve feedback from #637
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Creating an otelcol Dockerfile for windows. * Adding circleci pipeline * Updating documentation for mounting config file * Update docs/getting-started/windows-manual.md Co-authored-by: Jeff Cheng <[email protected]> * Update docs/getting-started/windows-manual.md Co-authored-by: Jeff Cheng <[email protected]> * Updating documentation * Updating circleci to save the image archive Co-authored-by: Jeff Cheng <[email protected]>
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
* promote povilasv * Update codeowners * Update company info
sneaker-dev
added a commit
to sneaker-dev/opentelemetry-collector
that referenced
this pull request
Sep 15, 2025
Resolve feedback from open-telemetry/opentelemetry-collector#637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.