Resolve feedback from #637

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

translator/metrics/otlp_to_oc.go

@@ -49,13 +49,13 @@ func ResourceMetricsToMetricsData(resourceMetrics *otlpmetrics.ResourceMetrics)
 		Resource: resource,
 	}
 
-	// TODO: Do not ignore InstrumentationLibrary properties
-
 	if len(resourceMetrics.InstrumentationLibraryMetrics) == 0 {
 		return md
 	}
 
-	// This is a size approximation.
+	// Allocate slice with a capacity approximated for the case when there is only one
+	// InstrumentationLibrary or the first InstrumentationLibrary contains most of the data.
+	// This is a best guess only that reduced slice re-allocations.
 	metrics := make([]*ocmetrics.Metric, 0, len(resourceMetrics.InstrumentationLibraryMetrics[0].Metrics))
 	for _, il := range resourceMetrics.InstrumentationLibraryMetrics {
 		for _, metric := range il.Metrics {

translator/trace/otlp_to_oc.go

@@ -52,13 +52,13 @@ func ResourceSpansToTraceData(resourceSpans *otlptrace.ResourceSpans) consumerda
 		SourceFormat: sourceFormat,
 	}
 
-	// TODO: Do not ignore InstrumentationLibrary properties
-
 	if len(resourceSpans.InstrumentationLibrarySpans) == 0 {
 		return td
 	}
 
-	// This is a size approximation.
+	// Allocate slice with a capacity approximated for the case when there is only one
+	// InstrumentationLibrary or the first InstrumentationLibrary contains most of the data.
+	// This is a best guess only that reduced slice re-allocations.
 	spans := make([]*octrace.Span, 0, len(resourceSpans.InstrumentationLibrarySpans[0].Spans))
 	for _, ils := range resourceSpans.InstrumentationLibrarySpans {
 		for _, span := range ils.Spans {