Move configcheck.ValidateConfigFromFactories to service package #4055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: revert all the renamed variables
fix: rename ValidateConfig to CheckConfigStruct
fix: rename test names
bogdandrutu
reviewed
Sep 16, 2021
6 tasks
…nto 3876-moveconfigcheck
|
@bogdandrutu updated! |
Aneurysm9
approved these changes
Sep 17, 2021
…nto 3876-moveconfigcheck
|
@jpkrohling @Aneurysm9 I think this check is useful, the reason to move it here is to limit the public API, but probably this should be a "test" in the builder instead of a test at runtime? What do you think? I am happy to merge it as is for the moment, but I would propose that the builder also has some "checks/validations" like this one as a pre-build step. What do you think? |
added 3 commits
September 20, 2021 11:29
…nto 3876-moveconfigcheck
…nto 3876-moveconfigcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR moves configcheck.ValidateConfigFromFactories into service package and makes the function unexported one.
Note: This PR is blocked by this PR #3956 so this PR should be merged after the PR #3956 is merged.Link to tracking Issue:
#3876