Move ValidateConfig from configcheck to configtest #3956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Sep 1, 2021
bogdandrutu
approved these changes
Sep 7, 2021
bogdandrutu
reviewed
Sep 7, 2021
fix: revert all the renamed variables
|
@bogdandrutu can you merge? |
|
@alolita I cannot since I asked for changes and they are not "resolved" - either implemented or explained why not to. |
added 2 commits
September 11, 2021 11:10
fix: rename ValidateConfig to CheckConfigStruct
|
@bogdandrutu changed only for ValidateConfig() to CheckConfigStruct() |
bogdandrutu
approved these changes
Sep 14, 2021
|
@Aneurysm9 can you please review too? So that @bogdandrutu can merge :-) |
Aneurysm9
approved these changes
Sep 14, 2021
6 tasks
added 3 commits
September 14, 2021 13:34
alolita
approved these changes
Sep 14, 2021
alolita
added
the
ready-to-merge
|
@bogdandrutu please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR moves ValidateConfig from being used in configcheck to configtest and updates the import path usages.
Link to tracking Issue:
#3875