Return permanent errors in prometheus remote write exporter #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2053 +/- ##
=======================================
Coverage 92.04% 92.05%
=======================================
Files 278 278
Lines 16753 16755 +2
=======================================
+ Hits 15421 15423 +2
Misses 915 915
Partials 417 417
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Nov 2, 2020
bogdandrutu
reviewed
Nov 2, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
) * Inventory the documentation for and examples of the OTLP exporter. * modify the documentation for otlptrace exporter. * Update exporters/otlp/otlptrace/README.md Co-authored-by: Robert Pająk <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Robert Pająk <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Tyler Yahn <[email protected]> * add otlptrace example_test.go * modify the documentation for otlptrace exporter. * modify the documentation for otlptrace exporter. * Update exporters/otlp/otlptrace/example_test.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/otlptrace/example_test.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/otlptrace/example_test.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Robert Pająk <[email protected]> * modify the documentation for otlptrace exporter. * Update exporters/otlp/otlptrace/README.md Co-authored-by: Robert Pająk <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Robert Pająk <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Robert Pająk <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/otlptrace/README.md Co-authored-by: Tyler Yahn <[email protected]> * Move example to otlptracehttp package * Unexport example functions * Fix markdownlint errors * Specify payload types in README Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* new example showing how the collector can assign different sourcetypes to different log sources * address review comments
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reworking of PR: #1734
The requested functionality of modifying componenterror.CombineErrors() has since been done, all that is left is to actually return permanent errors in the exporter
Link to tracking Issue: #1733