Skip to content

Return consumererror.Permanent in the Prometheus remote write exporter #1733

@huyan0

Description

@huyan0

The Prometheus remote write exporter right now returns vanilla Go errors. This breaks the retry mechanism in the Collector. If a batch contains a metric with invalid temporailty or it gets a 400 response code from the backend, the collector will exponentially backoff and retry, getting the same error every time.

If the Prometheus remote write returns error of consumererror.Permanent type, the retry mechanism will not be triggered

cc: @bogdandrutu @alolita @huyan0

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions