[confighttp] Remove pointer in CookiesConfig field #13116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13116 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 506 506
Lines 28544 28544
=======================================
Hits 26147 26147
Misses 1882 1882
Partials 515 515 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iblancasa
approved these changes
May 29, 2025
songy23
approved these changes
May 29, 2025
bogdandrutu
approved these changes
Jun 1, 2025
Merged
via the queue into
open-telemetry:main
with commit Jun 2, 2025
4396505
59 of 63 checks passed
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Jun 2, 2025
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Removes pointer to `CookiesConfig` field. Since the struct already has an `enabled` field, it is unnecessary for it to be a pointer. This is a breaking change, contrib tests show that it does not affect any contrib component, and it would be hard to do in two steps. <!-- Issue number if applicable --> #### Link to tracking issue Updates open-telemetry#9478
malus2077
pushed a commit
to malus2077/opentelemetry-collector
that referenced
this pull request
Jun 3, 2025
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Removes pointer to `CookiesConfig` field. Since the struct already has an `enabled` field, it is unnecessary for it to be a pointer. This is a breaking change, contrib tests show that it does not affect any contrib component, and it would be hard to do in two steps. <!-- Issue number if applicable --> #### Link to tracking issue Updates open-telemetry#9478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes pointer to
CookiesConfigfield. Since the struct already has anenabledfield, it is unnecessary for it to be a pointer.This is a breaking change, contrib tests show that it does not affect any contrib component, and it would be hard to do in two steps.
Link to tracking issue
Updates #9478