Skip to content

[confighttp] Use configoptional.Optional for optional fields #13109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented May 28, 2025

Description

Makes the following changes to confighttp:

  1. Uses configoptional.Optional in confighttp for all optional sections

This means a bunch of breaking changes. I think it is unfeasible to do this in two steps and I hereby promise that I will fix contrib tests and help anybody affected by this

Link to tracking issue

Fixes #9478

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (633b6de) to head (b8a4d7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13109   +/-   ##
=======================================
  Coverage   91.59%   91.60%           
=======================================
  Files         506      506           
  Lines       28534    28537    +3     
=======================================
+ Hits        26137    26140    +3     
  Misses       1882     1882           
  Partials      515      515           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi mx-psi marked this pull request as ready for review May 28, 2025 16:37
@mx-psi mx-psi requested a review from a team as a code owner May 28, 2025 16:37
@mx-psi
Copy link
Member Author

mx-psi commented May 29, 2025

I split off a couple of changes into separate PRs since those are clearer to me:

@mx-psi
Copy link
Member Author

mx-psi commented May 29, 2025

Also, since I guess it is clear that configoptional.Optional is a good fit for the OTLP receiver I will start with that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confighttp] Review usage of 'pointer to type'
3 participants