-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[confighttp] Use configoptional.Optional
for optional fields
#13109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[confighttp] Use configoptional.Optional
for optional fields
#13109
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13109 +/- ##
=======================================
Coverage 91.59% 91.60%
=======================================
Files 506 506
Lines 28534 28537 +3
=======================================
+ Hits 26137 26140 +3
Misses 1882 1882
Partials 515 515 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I split off a couple of changes into separate PRs since those are clearer to me: |
Also, since I guess it is clear that |
Description
Makes the following changes to confighttp:
configoptional.Optional
inconfighttp
for all optional sectionsThis means a bunch of breaking changes. I think it is unfeasible to do this in two steps and I hereby promise that I will fix contrib tests and help anybody affected by this
Link to tracking issue
Fixes #9478