[metadatatest] Generate NewSettings that accepts componenttest.Telemetry #12216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
newsettings
branch
from
15adcbb to
516a8c1
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (77.01%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12216 +/- ##
==========================================
- Coverage 91.29% 91.22% -0.07%
==========================================
Files 465 465
Lines 25629 25647 +18
==========================================
Hits 23397 23397
- Misses 1819 1837 +18
Partials 413 413 ☔ View full report in Codecov by Sentry. |
bogdandrutu
force-pushed
the
newsettings
branch
2 times, most recently
from
a21490e to
4140fce
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
newsettings
branch
from
4140fce to
e51bc79
Compare
bogdandrutu
commented
Jan 30, 2025
| @@ -49,7 +49,7 @@ type Telemetry struct { | |||
| traceProvider *sdktrace.TracerProvider | |||
| } | |||
|
|
|||
| func NewTelemetry(opts ...TelemetryOption) Telemetry { | |||
| func NewTelemetry(opts ...TelemetryOption) *Telemetry { | |||
There was a problem hiding this comment.
Not a breaking change because it was added this release.
bogdandrutu
added
Skip Changelog
dmitryax
approved these changes
Jan 30, 2025
Merged
via the queue into
open-telemetry:main
with commit Jan 30, 2025
d9b97ff
95 of 114 checks passed
sfc-gh-sili
pushed a commit
to sfc-gh-sili/opentelemetry-collector
that referenced
this pull request
Feb 3, 2025
…try (open-telemetry#12216) This is the last functionality needed to replace `metadatatest.Telemetry` with `componenttest.Telemetry`. The `metadatatest.Telemetry` will be deprecated next release to give time to change contrib since it is a large change. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last functionality needed to replace
metadatatest.Telemetrywithcomponenttest.Telemetry.The
metadatatest.Telemetrywill be deprecated next release to give time to change contrib since it is a large change.