[chore] Replace usage of metadatatest.SetupTelemetry with new componentest #37613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
exporter/prometheusremotewrite
processor/groupbyattrs
github-actions
bot
requested review from
Aneurysm9,
ArthurSens,
mcardy,
rapphil and
rnishtala-sumo
bogdandrutu
force-pushed
the
rm-more-usage-metadatatest
branch
from
7d9ec13 to
e8ef187
Compare
…ntest Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
rm-more-usage-metadatatest
branch
from
e8ef187 to
73e8921
Compare
dashpole
approved these changes
Jan 31, 2025
crobert-1
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Is there any issue that's tracking this effort, or shows discussion around it? I see the goal is to deprecate metadatatest.Telemetry, but was looking for more context.
songy23
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Seems this broke prometheus compliance test https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13077774964/job/36494038818
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…ntest (open-telemetry#37613) Signed-off-by: Bogdan Drutu <[email protected]>
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…ntest (open-telemetry#37613) Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.