[cmd/mdatagen] Fixed bug in component_test.go.tmpl #10882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamerJ
changed the title
SamerJ
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10882 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 406 406
Lines 19046 19046
=======================================
Hits 17450 17450
Misses 1237 1237
Partials 359 359 ☔ View full report in Codecov by Sentry. |
SamerJ
force-pushed
the
bugfix
branch
2 times, most recently
from
0960e8e to
8188e08
Compare
Contributor
Author
|
Hello @jpkrohling, All checks for the PR are green. Should I rebase my PR on the latest commit every now and then or should I leave the PR? Thanks in Advanace |
When SkipLifecycle & SkipShutdown are set to true, the generated file will have an unused import confmaptest
codeboten
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SkipLifecycle & SkipShutdown are set to true, the generated file will have an unused import
confmaptestDescription
The Metadata Generator had a bug described above, With this change, that issue has been addressed.
Link to tracking issue
Fixes #10866