Skip to content

Commit 1c20608

Browse files
SamerJcodeboten
andauthored
[cmd/mdatagen] Fixed bug in component_test.go.tmpl (#10882)
When SkipLifecycle & SkipShutdown are set to true, the generated file will have an unused import `confmaptest` #### Description The Metadata Generator had a bug described above, With this change, that issue has been addressed. #### Link to tracking issue Fixes #10866 --------- Co-authored-by: Alex Boten <[email protected]>
1 parent 18d5c02 commit 1c20608

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

.chloggen/mdatagen-test-gen.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: mdatagen
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Fixed bug in which setting `SkipLifecycle` & `SkipShutdown` to true would result in a generated file with an unused import `confmaptest`
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [10866]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: []

cmd/mdatagen/templates/component_test.go.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ import (
2020
"go.opentelemetry.io/collector/component"
2121
{{- end }}
2222
"go.opentelemetry.io/collector/component/componenttest"
23-
"go.opentelemetry.io/collector/confmap/confmaptest"
2423
{{- if not (and .Tests.SkipLifecycle .Tests.SkipShutdown) }}
24+
"go.opentelemetry.io/collector/confmap/confmaptest"
2525
{{- if isExporter }}
2626
"go.opentelemetry.io/collector/exporter"
2727
"go.opentelemetry.io/collector/exporter/exportertest"

0 commit comments

Comments
 (0)