[confighttp,configgrpc] Rename TLSSetting to TLS #13115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/tlssetting-to-tls
branch
from
67c43ee to
3d754bb
Compare
mx-psi
force-pushed
the
mx-psi/tlssetting-to-tls
branch
from
3d754bb to
d8a565f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13115 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 508 508
Lines 28682 28682
=======================================
Hits 26171 26171
Misses 1994 1994
Partials 517 517 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
approved these changes
Jun 1, 2025
evan-bradley
approved these changes
Jun 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Merged
via the queue into
open-telemetry:main
with commit Jun 3, 2025
605011a
44 of 56 checks passed
|
it seems like this broke many of the contrib tests, is this something that needs to be addressed in contrib components or can we add a fallback here? nvm: I see this open-telemetry/opentelemetry-collector-contrib#40446 |
|
Sorry, I went to have lunch while fixing this. open-telemetry/opentelemetry-collector-contrib/pull/40455 is the PR we need |
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jun 3, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Renames TLSSetting to TLS. Counterpart to open-telemetry/opentelemetry-collector#13115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames
TLSSettingfields toTLS. The name is a historical artifact since theconfigtlshadSettingin the name before. This is more consistent with the rest.I think if we do this change we should do it alongside other changes to confighttp, to avoid breaking our users multiple times.