Fix: update go.mod to ensure contrib tests pass after TLS validation #40446
Conversation
|
Reference to failing tests on the collector: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/15413949821/job/43372738556?pr=13134 I don't think this is the proper solution. There are tests in this repository that don't properly configure the TLS configuration. This is what should be fixed. |
| @@ -16,3 +16,5 @@ retract ( | |||
| v0.65.0 | |||
| v0.37.0 // Contains dependencies on v0.36.0 components, which should have been updated to v0.37.0. | |||
| ) | |||
|
|
|||
| replace github.com/open-telemetry/opentelemetry-collector => ../opentelemetry-collector | |||
There was a problem hiding this comment.
This only works locally. Tests need to be fixed in http://github.com/open-telemetry/opentelemetry-collector-contrib/pull/40452
There was a problem hiding this comment.
you're saying the failing tests should be modified in that PR updating the collector core dependencies?
There was a problem hiding this comment.
Yes since #40452 brings the latest core collector changes (including the breaking changes)
Description
This PR updates the go.mod file to reference the latest commit from the core OpenTelemetry Collector that includes the new TLS certificate/key validation logic.
The validation introduced in open-telemetry/opentelemetry-collector#13134 causes some contrib components to fail tests due to missing or invalid TLS config. By aligning the go.mod, we ensure contrib is compatible with the updated validation rules.
Link to tracking issue
Related to open-telemetry/opentelemetry-collector#13134
Testing
Ran go test ./... in the relevant receivers (e.g. otlpjsonfilereceiver) to ensure tests pass with the updated validation logic.
Documentation
No new documentation was added.