[chore] prom translation rw2 add support for histogram #40494
Conversation
|
Review please @dashpole @ArthurSens @ywwg @krajorama |
| // omitted | ||
| if pt.HasSum() { | ||
| // treat sum as a sample in an individual TimeSeries | ||
| sum := &writev2.Sample{ |
There was a problem hiding this comment.
I thought histograms were sent as writev2.Histogram so that they are atomic?
There was a problem hiding this comment.
ah forgot about that let me fix it
There was a problem hiding this comment.
I need to re-read RW2 spec...
There was a problem hiding this comment.
So looking at https://github.com/prometheus/prometheus/blob/e7e3ab282431de827ee7d03d27d056551a134e6a/storage/remote/queue_manager.go#L1914 and doing some testing locally looks like, normal histograms with buckets are still treated as separate series in remote write, and I guess only the new native histograms are send as writev2.Histogram, but I think I remember there being some discussion about translating normal histograms into native histograms let me try and find it.
|
My understanding of conventional commit style is that "chore" is for routine maintenance that does not affect production: "tool changes, configuration changes, and changes to things that do not actually go into production at all.". So this I would actually call "feat" because it is new functionality. |
Description
Adds support for adding histograms in the RW2 translation path.
Link to tracking issue
Fixes
Partially implements #33661 (when merging PR please don't close the tracing issue)
Testing
Histogram metrics in prometheus ui
