[chore] prom translation rw2 add support for target_info #40493
+224
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmichalek132
changed the title
jmichalek132
commented
Jun 4, 2025
jmichalek132
commented
Jun 4, 2025
|
Review please @dashpole @ArthurSens @ywwg @krajorama |
23 tasks
ArthurSens
reviewed
Jun 5, 2025
dashpole
reviewed
Jun 5, 2025
dashpole
approved these changes
Jun 5, 2025
Co-authored-by: David Ashpole <[email protected]>
|
similar to #40494, this is feat, not a chore |
ywwg
reviewed
Jun 6, 2025
| // convert ns to ms | ||
| Timestamp: convertTimeStamp(timestamp), | ||
| } | ||
| converter.addSample(sample, labels, metadata{ |
There was a problem hiding this comment.
is there a reason this is a pure function with the converter as a parameter instead of making this just a member of converter? I think that would make the function calls more clear:
c.AddResourceTargetInfoV2(resource, settings, mostRecentTimestamp)
| name := prometheustranslator.TargetInfoMetricName | ||
| if len(settings.Namespace) > 0 { | ||
| // TODO what to do with this in case of full utf-8 support? | ||
| name = settings.Namespace + "_" + name |
There was a problem hiding this comment.
we have functions like "BuildCompliantMetricName" that take care of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for adding target_info in the RW2 translation path.
Link to tracking issue
Fixes
Partially implements #33661 (when merging PR please don't close the tracing issue)
Testing
Target_info in prometheus.
